Return value of c_trace?

I use the following line of code to evaluate whether there is a line of sight between player and NPC.



I assumed if the trace hits the player unhindered, the return value would be 0. My if-statement therefore triggers the NPC-action if it is 0.

It does not trigger it. What do I do wrong?

c_trace returns 0 when nothing is hit, otherwise the return value is non-zero. Note though that hit could mean that anything was hit, not just the player, so you should check wether you is equal to the player.

Got it. There is a me, there is a you. The latter was unknown to me.

BTW.: To avoid "empty pointer" errors please check YOU before using it fex.:

That's not needed Rayp, you can compare a nullpointer to any other pointer just fine, you just can't dereference it.

Ah ok.
so this is ok:


and the check is only needed here

If you can guarantee that player is always unequal to NULL, you can omit the second check and just access you directly (given that both if() are related obviously). This would also work if you don't know wether player is NULL or not:

This is how i use to make it (almost ever). Guess its the most secured way.

It's not though. Like I said, if you know that player is always unequal to NULL, you can simply remove the check wether you is NULL or not, because if it is equal to player, it's definitely not NULL. If you don't know if player is NULL or not, you can put the check wether you is NULL or not together into the same if and make your code cleaner and easier to read

I just wanted to say if hes not sure if you != 0 he should check it before.
But i got your points, thank you.